fix: Don't fetch the current item for a null test session #2469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hectoras
force-pushed
the
fix/INF-268-prevent-adjusttimers-error-on-execution-with-no-session
branch
from
ab125c2 to
9c69e78
Compare
Front-end summary Node 18
|
gabrielfs7
reviewed
May 16, 2024
Version
There are 0 BREAKING CHANGE, 0 feature, 1 fix |
gabrielfs7
reviewed
May 17, 2024
| @@ -67,15 +69,19 @@ public function __construct( | |||
| DeliveryExecutionService $deliveryExecutionService, | |||
| FeatureFlagCheckerInterface $featureFlagChecker, | |||
| StateServiceInterface $stateService, | |||
| TestSessionService $testSessionService, | |||
There was a problem hiding this comment.
- Can you please make sure there is no other DI Service provider instantiating this class apart of
TestQtiServiceProvider? Thanks!
There was a problem hiding this comment.
I've just checked and it is only used in the TestQtiServiceProvider from this extension, and all instantiations at runtime are done though the PSR container.
gabrielfs7
approved these changes
May 17, 2024
There was a problem hiding this comment.
LGTM, Code looks good, but I cannot check it.
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
shpran
approved these changes
May 17, 2024
|
These changes have two approvals and the fix was validated by QA, therefore I'm merging this PR. |
hectoras
deleted the
fix/INF-268-prevent-adjusttimers-error-on-execution-with-no-session
branch
|
Released as v48.5.2. |
pnal
pushed a commit
that referenced
this pull request
Jun 6, 2024
* fix: Don't fetch the current item for a null test session * chore: Use DI to fetch services from ConcurringSessionService * chore: Fix tests (cherry picked from commit c22ae07)
pnal
added a commit
that referenced
this pull request
Jun 6, 2024
…ntAssessmentAtemRef-on-null fix: Don't fetch the current item for a null test session (#2469)
wazelin
pushed a commit
that referenced
this pull request
Jun 10, 2024
* fix: Don't fetch the current item for a null test session * chore: Use DI to fetch services from ConcurringSessionService * chore: Fix tests (cherry picked from commit c22ae07)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated Jira issue: INF-268
Fixes a race condition that happens when the same test taker launches two executions concurrently, causing the logic to pause the timers for the first one that got processed to try to fetch a test session that may not have been persisted yet.
Changelog:
getCurrentAssessmentItemRef()onnullwhen an execution does not have a test session assigned (yet)suspend()the same delivery execution twiceThis fixes a customer-reported error, and has already been validated on their side. The error was: